On 2013/10/29 16:11:18, Sam Clegg wrote:
On 2013/10/29 15:49:58, Torne wrote:
> On 2013/10/29 15:45:17, Sam Clegg wrote:
> > On 2013/10/29 12:59:18, Torne wrote:
> > > On 2013/10/29 12:58:16, ulan wrote:
> > > > This also will affect standalone builds of V8 for Android. I
uploaded
a
> fix
> > > > https://chromiumcodereview.appspot.com/46043015/
> > >
> > > For WebView we explicitly do not want to *ever* pass any compiler
flags
from
> > gyp
> > > that indicate CPU type/features/optimisation, because we want to
leave
the
> > > platform build's defaults alone. So, that kind of fix won't work for
> WebView.
> >
> > Thats what I'm trying to achieve with the linux build too. Just rely
> > on the default for the compiler (either arm-linux-gnueabi-gcc or
> > arm-linux-gnueabihf-gcc) and avoid passing this superfluous option to
the
> > compiler (that could contradict the ABI of the compiler's libs).
> >
> > This seems to work fine in all cases except for V8 which IIUC needs
> > to build host (x86) binaries that target the target arch (arm). In
> > this case it seems that V8 can't detect the float ABI and relies on
> > gyp to set USE_EABI_HARDFLOAT at gyp time. I'm assuming that if
> > the host binaries have the wrong value for USE_EABI_HARDFLOAT then
> > things could go badly go wrong, is that right?
> >
> > Maybe when arm_float_abi is left blank we can detect the value of
> > USE_EABI_HARDFLOAT by running the compiler with -v? I'll have
> > a go at that.
>
> This approach won't work for the webview; there's no way to know what
flags
will
> be passed to the compiler until build time (when the android build
system is
> invoked). At gyp time there is no way to tell what -mfloat-abi the
target
will
> use. I believe the actual answer in practise is that Android always uses
softfp,
> but this may not be true forever..
And when you build the webview, I guess you also build the host binary
(mksnapshot)? Perhaps we just need to make the default be softfp for
android
and try to autodetect on linux? Then android will need to deal with the
hardfp issue when it arises.
Probably. digit@ would know better about whether this is ever not softfp on
android..
https://codereview.chromium.org/48113015/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
