LGTM with comments.
https://codereview.chromium.org/50563003/diff/1/src/math.js
File src/math.js (right):
https://codereview.chromium.org/50563003/diff/1/src/math.js#newcode220
src/math.js:220: var samples = 2048; // Table size;
nit: s/size;/size./
https://codereview.chromium.org/50563003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/50563003/diff/1/src/objects.cc#newcode9960
src/objects.cc:9960: if (code()->kind() == Code::OPTIMIZED_FUNCTION)
return true;
I know you just moved this line around, but I think this never can and
never could happen.
https://codereview.chromium.org/50563003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/50563003/diff/1/src/runtime.cc#newcode7879
src/runtime.cc:7879: for (int i = 1; i < samples + 1; i++) {
i = 1? Why not i = 0?
https://codereview.chromium.org/50563003/diff/1/test/mjsunit/sin-cos.js
File test/mjsunit/sin-cos.js (right):
https://codereview.chromium.org/50563003/diff/1/test/mjsunit/sin-cos.js#newcode70
test/mjsunit/sin-cos.js:70: var terms = [];
Might wanna add a comment here that the reason for the "needless"
allocation is that we sum up the terms in reverse order for increased
precision.
https://codereview.chromium.org/50563003/diff/1/test/mjsunit/sin-cos.js#newcode123
test/mjsunit/sin-cos.js:123: // Sum squares up by adding them pairwise,
to avoid not losing precision.
s/not // ;-)
https://codereview.chromium.org/50563003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
