andreas: PTAL
https://codereview.chromium.org/47703003/diff/70001/src/object-observe.js
File src/object-observe.js (right):
https://codereview.chromium.org/47703003/diff/70001/src/object-observe.js#newcode448
src/object-observe.js:448: if (arguments.length == 2) {
(talked with arv off-line). This is internal-only API.
On 2013/10/29 21:58:18, arv wrote:
This is tangential but ES does not usually use the length of
arguments.
https://codereview.chromium.org/47703003/diff/70001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/47703003/diff/70001/src/objects.cc#newcode5527
src/objects.cc:5527: ASSERT(!object->map()->is_observed());
That's what the assertion is documenting. If you feel strongly, I'll put
a comment, but it seems superfluous.
On 2013/10/29 21:58:18, arv wrote:
Might be worth pointing out that we use a different code path for
observed
objects.
https://codereview.chromium.org/47703003/diff/70001/test/mjsunit/harmony/object-observe.js
File test/mjsunit/harmony/object-observe.js (right):
https://codereview.chromium.org/47703003/diff/70001/test/mjsunit/harmony/object-observe.js#newcode305
test/mjsunit/harmony/object-observe.js:305: var obj = { foo: 'bar '};
good catch. done.
On 2013/10/29 21:58:18, arv wrote:
bar' }
instead of
bar '}
https://codereview.chromium.org/47703003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
