thanks for doing this!
https://codereview.chromium.org/54393002/diff/100001/src/hydrogen-uint32-analysis.cc
File src/hydrogen-uint32-analysis.cc (right):
https://codereview.chromium.org/54393002/diff/100001/src/hydrogen-uint32-analysis.cc#newcode43
src/hydrogen-uint32-analysis.cc:43: ASSERT(!use->IsChange() ||
I would make it
else if (use->IsSimulate()) {
// Deoptimization has special support.
return true;
} else if (use->IsChange()) {
// Conversion has special support. This assert (the rest of the
comment)...
ASSERT(...);
}
to not have somewhat confusing !use->IsChange()
https://codereview.chromium.org/54393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
