lgtm
https://codereview.chromium.org/54823002/diff/90001/src/ia32/assembler-ia32-inl.h
File src/ia32/assembler-ia32-inl.h (right):
https://codereview.chromium.org/54823002/diff/90001/src/ia32/assembler-ia32-inl.h#newcode256
src/ia32/assembler-ia32-inl.h:256: Assembler::set_target_address_at(pc_,
pc_ + sizeof(int32_t));
Why add sizeof(int32_t) here?
https://codereview.chromium.org/54823002/diff/90001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/54823002/diff/90001/src/objects.h#newcode5199
src/objects.h:5199: // Slightly ugly, used in ObjectSerializer only.
Rather than insulting your own code it would be more helpful to spend a
few words explaining why it's needed.
https://codereview.chromium.org/54823002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
