Addressed comments, PTAL again.
https://chromiumcodereview.appspot.com/23537067/diff/13001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://chromiumcodereview.appspot.com/23537067/diff/13001/src/ia32/lithium-ia32.cc#newcode1403
src/ia32/lithium-ia32.cc:1403: if (instr->IsTailCall()) return
DefineFixed(result, eax);
On 2013/10/11 16:13:24, danno wrote:
nit: I think I would it better if you did:
LInstruction* result = DefineFixed(result, eax);
return instr->IsTailCall() ? result : MarkAsCall(result);
Done.
https://chromiumcodereview.appspot.com/23537067/diff/13001/src/ic.cc
File src/ic.cc (right):
https://chromiumcodereview.appspot.com/23537067/diff/13001/src/ic.cc#newcode841
src/ic.cc:841: if (object->IsJSArray() && key->IsSmi()) {
On 2013/10/11 16:13:24, danno wrote:
Some comments for this logic would be good. It's not clear to me what
the next
15 lines is trying to accomplish without perusing the code.
Done.
https://chromiumcodereview.appspot.com/23537067/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
