Thx for the comments, updated, along with a test.
--Michael
https://codereview.chromium.org/54333003/diff/1/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/54333003/diff/1/src/objects.cc#oldcode5840
src/objects.cc:5840:
isolate->counters()->cow_arrays_created_runtime()->Increment();
On 2013/11/04 14:12:03, Michael Starzinger wrote:
This removes the accounting of cloned CoW arrays in nested object
structures. Is
that on purpose? I think we should leave this accounting intact as it
currently
is and instead remove the special-casing in Runtime_CreateArrayLiteral
that just
accounts for the outermost object in nested structures.
Thanks, I was trying to avoid double counting but made a mistake. I've
just ensured the increment runs if we are doing a copying visit through
the object.
https://codereview.chromium.org/54333003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/54333003/diff/1/src/runtime.cc#newcode571
src/runtime.cc:571:
isolate->counters()->cow_arrays_created_runtime()->Increment();
On 2013/11/04 14:12:03, Michael Starzinger wrote:
See comments in objects.cc about this.
Right on, removed this code.
https://codereview.chromium.org/54333003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
