Reviewers: Toon Verwaest,
Description:
Fix double-boxing issue when materializing captured objects.
[email protected]
TEST=mjsunit/compiler/escape-analysis-representation
Please review this at https://codereview.chromium.org/57783003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M src/deoptimizer.cc
Index: src/deoptimizer.cc
diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc
index
84e80b9d9a0c86fa8c859f7bb068fbce68f4d121..96871d610f48d09f367d30d56149d6001aaa3d95
100644
--- a/src/deoptimizer.cc
+++ b/src/deoptimizer.cc
@@ -1620,10 +1620,10 @@ Handle<Object>
Deoptimizer::MaterializeNextHeapObject() {
Handle<Map>::cast(MaterializeNextValue()),
Representation::Tagged());
switch (map->instance_type()) {
case HEAP_NUMBER_TYPE: {
- Handle<HeapNumber> object =
isolate_->factory()->NewHeapNumber(0.0);
+ // Reuse the HeapNumber value directly as it is already properly
+ // tagged and skip materializing the HeapNumber explicitly.
+ Handle<Object> object = MaterializeNextValue();
materialized_objects_->Add(object);
- Handle<Object> number = MaterializeNextValue();
- object->set_value(number->Number());
materialization_value_index_ += kDoubleSize / kPointerSize - 1;
break;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
