Revision: 17496
Author: [email protected]
Date: Tue Nov 5 15:33:14 2013 UTC
Log: Remove SetLocalPropertiesIgnoreAttributesTrampoline
BUG=v8:2877
[email protected]
Review URL: https://codereview.chromium.org/59343003
http://code.google.com/p/v8/source/detail?r=17496
Modified:
/branches/bleeding_edge/src/objects.cc
/branches/bleeding_edge/src/objects.h
=======================================
--- /branches/bleeding_edge/src/objects.cc Tue Nov 5 14:07:07 2013 UTC
+++ /branches/bleeding_edge/src/objects.cc Tue Nov 5 15:33:14 2013 UTC
@@ -4120,29 +4120,6 @@
return result;
}
-
-
-MaybeObject* JSObject::SetLocalPropertyIgnoreAttributesTrampoline(
- Name* key,
- Object* value,
- PropertyAttributes attributes,
- ValueType value_type,
- StoreMode mode,
- ExtensibilityCheck extensibility_check) {
- // TODO(mstarzinger): The trampoline is a giant hack, don't use it
anywhere
- // else or handlification people will start hating you for all eternity.
- HandleScope scope(GetIsolate());
- IdempotentPointerToHandleCodeTrampoline trampoline(GetIsolate());
- return trampoline.CallWithReturnValue(
- &JSObject::SetLocalPropertyIgnoreAttributes,
- Handle<JSObject>(this),
- Handle<Name>(key),
- Handle<Object>(value, GetIsolate()),
- attributes,
- value_type,
- mode,
- extensibility_check);
-}
// Set a real local property, even if it is READ_ONLY. If the property is
not
=======================================
--- /branches/bleeding_edge/src/objects.h Tue Nov 5 14:07:07 2013 UTC
+++ /branches/bleeding_edge/src/objects.h Tue Nov 5 15:33:14 2013 UTC
@@ -2193,15 +2193,6 @@
// or returns an empty handle if such a map is not yet available.
static Handle<Object> TryMigrateInstance(Handle<JSObject> instance);
- // Can cause GC.
- MUST_USE_RESULT MaybeObject* SetLocalPropertyIgnoreAttributesTrampoline(
- Name* key,
- Object* value,
- PropertyAttributes attributes,
- ValueType value_type = OPTIMAL_REPRESENTATION,
- StoreMode mode = ALLOW_AS_CONSTANT,
- ExtensibilityCheck extensibility_check =
PERFORM_EXTENSIBILITY_CHECK);
-
// Retrieve a value in a normalized object given a lookup result.
// Handles the special representation of JS global objects.
Object* GetNormalizedProperty(LookupResult* result);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
