lgtm if comments are addressed.
https://codereview.chromium.org/57383004/diff/110001/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
https://codereview.chromium.org/57383004/diff/110001/src/ia32/lithium-ia32.cc#newcode1880
src/ia32/lithium-ia32.cc:1880: ? UseFixedOrConstant(instr->value(), eax)
Why does this have to be fixed to eax, why not UseRegisterOrConstant?
https://codereview.chromium.org/57383004/diff/110001/test/mjsunit/string-natives.js
File test/mjsunit/string-natives.js (right):
https://codereview.chromium.org/57383004/diff/110001/test/mjsunit/string-natives.js#newcode45
test/mjsunit/string-natives.js:45:
assertEquals("AAAAAAAAAAAAAAAAAAAAAAAAAB", s2);
Please also add a test that tests non-latin1 characters and where the
character being set is not a constant.
https://codereview.chromium.org/57383004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
