Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r17523.
Description:
Another fix for windows breakage after r17521.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=17523
Please review this at https://codereview.chromium.org/61953002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M src/hydrogen-gvn.cc
Index: src/hydrogen-gvn.cc
diff --git a/src/hydrogen-gvn.cc b/src/hydrogen-gvn.cc
index
e3bf316f3790b555ef5fdf426e0f77a2b49745e2..02b3a0a2c94dc217f625f78556cf1ab8cb0e95c1
100644
--- a/src/hydrogen-gvn.cc
+++ b/src/hydrogen-gvn.cc
@@ -433,7 +433,7 @@ SmartArrayPointer<char> GetGVNFlagsString(GVNFlagSet
flags) {
uint32_t set_depends_on = 0;
uint32_t set_changes = 0;
for (int bit = 0; bit < kLastFlag; ++bit) {
- if ((flags.ToIntegral() & (1 << bit)) != 0) {
+ if (flags.Contains(static_cast<GVNFlag>(bit))) {
if (bit % 2 == 0) {
set_changes++;
} else {
@@ -450,7 +450,7 @@ SmartArrayPointer<char> GetGVNFlagsString(GVNFlagSet
flags) {
offset += OS::SNPrintF(buffer + offset, "changes all except [");
}
for (int bit = 0; bit < kLastFlag; ++bit) {
- if (((flags.ToIntegral() & (1 << bit)) != 0) == positive_changes) {
+ if (flags.Contains(static_cast<GVNFlag>(bit)) == positive_changes) {
switch (static_cast<GVNFlag>(bit)) {
#define DECLARE_FLAG(type) \
case kChanges##type: \
@@ -479,7 +479,7 @@ GVN_UNTRACKED_FLAG_LIST(DECLARE_FLAG)
offset += OS::SNPrintF(buffer + offset, "depends on all except [");
}
for (int bit = 0; bit < kLastFlag; ++bit) {
- if (((flags.ToIntegral() & (1 << bit)) != 0) == positive_depends_on)
{
+ if (flags.Contains(static_cast<GVNFlag>(bit)) ==
positive_depends_on) {
switch (static_cast<GVNFlag>(bit)) {
#define DECLARE_FLAG(type) \
case kDependsOn##type: \
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
