LGTM. Yes, to me personally it makes sense to move this functionality from
the
Runtime class into the JSObject class. I don't see a particular reason why
they
need/should live in the Runtime class, especially in light that they are
used by
the API (i.e. api.cc) as well.
https://codereview.chromium.org/61883002/diff/60001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/61883002/diff/60001/src/runtime.cc#newcode5087
src/runtime.cc:5087: name,
nit: Indentation is off.
https://codereview.chromium.org/61883002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
