https://chromiumcodereview.appspot.com/62223002/diff/60001/tools/lexer_generator/nfa.py
File tools/lexer_generator/nfa.py (right):
https://chromiumcodereview.appspot.com/62223002/diff/60001/tools/lexer_generator/nfa.py#newcode340
tools/lexer_generator/nfa.py:340: actions.append((action[2], action[0],
action[1]))
action should just always be (precedence, id, code), then no need for
all the reordering
https://chromiumcodereview.appspot.com/62223002/diff/60001/tools/lexer_generator/nfa.py#newcode343
tools/lexer_generator/nfa.py:343: # match state.
what's with all these spaces and comments - you want this code to be
readable?
https://chromiumcodereview.appspot.com/62223002/diff/60001/tools/lexer_generator/rule_parser.py
File tools/lexer_generator/rule_parser.py (right):
https://chromiumcodereview.appspot.com/62223002/diff/60001/tools/lexer_generator/rule_parser.py#newcode53
tools/lexer_generator/rule_parser.py:53: self.__rule_precedence_counter
= 0
should either be class static or go in RuleParserState
https://chromiumcodereview.appspot.com/62223002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
