Reviewers: Jakob,

Description:
Use a fixed random seed per default.

To get back the old behavior, use "make randomseed=0 ...".

BUG=v8:1880,v8:2885

Please review this at https://codereview.chromium.org/64093003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+10, -0 lines):
  M Makefile
  M tools/gyp/v8.gyp


Index: Makefile
diff --git a/Makefile b/Makefile
index bbec44076e41e35b30256e48ba0e1d6c466c109e..64bf7bca8dc735a3965b527b57acc3eff8267fb4 100644
--- a/Makefile
+++ b/Makefile
@@ -104,6 +104,10 @@ endif
 ifeq ($(unalignedaccess), on)
   GYPFLAGS += -Dv8_can_use_unaligned_accesses=true
 endif
+# randomseed=12345, disable random seed via randomseed=0
+ifdef randomseed
+  GYPFLAGS += -Dv8_random_seed=$(randomseed)
+endif
 # soname_version=1.2.3
 ifdef soname_version
   GYPFLAGS += -Dsoname_version=$(soname_version)
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index 22fcf94566f93c073f89eae287ead198a26521a8..2f22fc5e37f89e835ce239675d070ecd6b801dcd 100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -28,6 +28,7 @@
 {
   'variables': {
     'v8_code': 1,
+    'v8_random_seed%': 314159265,
   },
   'includes': ['../../build/toolchain.gypi', '../../build/features.gypi'],
   'targets': [
@@ -156,6 +157,11 @@
               '--log-snapshot-positions',
               '--logfile', '<(INTERMEDIATE_DIR)/snapshot.log',
             ],
+            'conditions': [
+              ['v8_random_seed!=0', {
+                'mksnapshot_flags': ['--random-seed', '<(v8_random_seed)'],
+              }],
+            ]
           },
           'action': [
             '<@(_inputs)',


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to