LGTM.
https://codereview.chromium.org/49653002/diff/330001/tools/push-to-trunk/common_includes.py
File tools/push-to-trunk/common_includes.py (right):
https://codereview.chromium.org/49653002/diff/330001/tools/push-to-trunk/common_includes.py#newcode76
tools/push-to-trunk/common_includes.py:76: return
subprocess.check_output("%s %s %s" % (prefix, cmd, args), shell=True)
nit: 80col (I'd break after '%')
https://codereview.chromium.org/49653002/diff/330001/tools/push-to-trunk/push_to_trunk.py
File tools/push-to-trunk/push_to_trunk.py (right):
https://codereview.chromium.org/49653002/diff/330001/tools/push-to-trunk/push_to_trunk.py#newcode126
tools/push-to-trunk/push_to_trunk.py:126: # TODO(machenbach): Handle
multiple entries (e.g. BUG=123, 234).
Agreed, this is one of the candidates for future improvement. The entire
workflow from lines 121 to 134 should be a helper function that takes
the output of "git log" and returns a beautifully formatted "(issue[s]
A, B, C; Chromium issue[s] D, E, F)" string. With proper tests for
pathological cases (including auto-detection of a missing "v8:" prefix!)
and all other bells and whistles you can think of :-)
Oh, and while we're at it, line breaks and trailing full stops should be
fixed globally, i.e. instead of this:
Fixed the foo when barring.
(issue 123,chromium:456)
I want this:
Fixed the foo when barring (issue 123, Chromium issue 456).
https://codereview.chromium.org/49653002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
