LGTM!
On 2013/11/08 14:44:48, Michael Starzinger wrote:
By now all allocations in new-space done by the runtime (not the generated
code)
go through Heap::AllocateRaw. This CL moves the allocation tracking into
the
same choke-point.
The same should be done for old-space as well, once the three remaining
call-sites in Heap::CreateCode and Heap::CopyCode are taken care of.
Yeah, we discussed this with Hannes here:
https://codereview.chromium.org/34733004#msg10 Spaces shouldn't be aware of
HeapProfiler, all hooks should ideally be in Heap.
Let me know if I missed any call-sites that the heap profiler was tracking
before but is not tracking now. Also note that this CL depends on
https://codereview.chromium.org/66723003/ to be landed first.
https://codereview.chromium.org/66683004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
