Reviewers: ,
Message:
Make v8::Function::GetScriptOrigin() set a value for
v8::ScriptOrigin::ResourceIsSharedCrossOrigin(). Before, the handle was
always
empty.
Description:
api: set ScriptOrigin::ResourceIsSharedCrossOrigin()
Please review this at https://codereview.chromium.org/68213002/
Affected files (+4, -1 lines):
M src/api.cc
M test/cctest/test-api.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
401007b4359b6c86c4184dd9183c561adb37a58f..f676b2d81eb8879b64fc61501ac14ccaacd9cc12
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -4149,7 +4149,8 @@ ScriptOrigin Function::GetScriptOrigin() const {
v8::ScriptOrigin origin(
Utils::ToLocal(scriptName),
v8::Integer::New(script->line_offset()->value()),
- v8::Integer::New(script->column_offset()->value()));
+ v8::Integer::New(script->column_offset()->value()),
+ v8::Boolean::New(script->is_shared_cross_origin()));
return origin;
}
return v8::ScriptOrigin(Handle<Value>());
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index
f33d02b729abdee20c0669ee2e0ecc46099b7966..485479e6f3ec3ca88d953d825e8b219e324a72db
100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -17484,10 +17484,12 @@ THREADED_TEST(ScriptOrigin) {
v8::ScriptOrigin script_origin_f = f->GetScriptOrigin();
CHECK_EQ("test", *v8::String::Utf8Value(script_origin_f.ResourceName()));
CHECK_EQ(0, script_origin_f.ResourceLineOffset()->Int32Value());
+ CHECK_EQ(false, script_origin_f.ResourceIsSharedCrossOrigin()->IsTrue());
v8::ScriptOrigin script_origin_g = g->GetScriptOrigin();
CHECK_EQ("test", *v8::String::Utf8Value(script_origin_g.ResourceName()));
CHECK_EQ(0, script_origin_g.ResourceLineOffset()->Int32Value());
+ CHECK_EQ(false, script_origin_g.ResourceIsSharedCrossOrigin()->IsTrue());
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
