LGTM with a few minor comments to address.
https://codereview.chromium.org/68723002/diff/1/src/assembler.cc
File src/assembler.cc (left):
https://codereview.chromium.org/68723002/diff/1/src/assembler.cc#oldcode1064
src/assembler.cc:1064: ExternalReference
ExternalReference::random_uint32_function(
Please also remove the declaration in the assembler.h file.
https://codereview.chromium.org/68723002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/68723002/diff/1/src/bootstrapper.cc#newcode2644
src/bootstrapper.cc:2644: factory()->NewHeapNumber(state[0]),
Better use Factory::NewNumberFromUint here and in the call below.
https://codereview.chromium.org/68723002/diff/1/src/math.js
File src/math.js (right):
https://codereview.chromium.org/68723002/diff/1/src/math.js#newcode180
src/math.js:180: random0 = r0;
I am not sure about the sequence of the initialization here. Can we make
sure that "random0" and "random1" are bound to global variables by
explicitly declaring them at the top-level a few lines above? Thereby it
is more obvious to where these two variables are bound.
https://codereview.chromium.org/68723002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
