Revision: 17620
Author:   [email protected]
Date:     Mon Nov 11 14:51:56 2013 UTC
Log:      Fix potential assertion failure in ConvertCase.

IsOneByteRepresentationUnderneath requires the string to be flat, which is not
guaranteed in this case.  Using IsOneByteRepresentation is sufficient here.

[email protected]
BUG=

Review URL: https://codereview.chromium.org/62493007
http://code.google.com/p/v8/source/detail?r=17620

Modified:
 /branches/bleeding_edge/src/runtime.cc

=======================================
--- /branches/bleeding_edge/src/runtime.cc      Fri Nov  8 17:09:14 2013 UTC
+++ /branches/bleeding_edge/src/runtime.cc      Mon Nov 11 14:51:56 2013 UTC
@@ -6444,7 +6444,7 @@
     }
   }

-  String::Encoding result_encoding = s->IsOneByteRepresentationUnderneath()
+  String::Encoding result_encoding = s->IsOneByteRepresentation()
       ? String::ONE_BYTE_ENCODING : String::TWO_BYTE_ENCODING;
   Object* answer;
   { MaybeObject* maybe_answer = ConvertCaseHelper(

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to