This just blows my mind. LGTM.
https://codereview.chromium.org/66983002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/66983002/diff/1/src/hydrogen.cc#newcode1164
src/hydrogen.cc:1164: set_current_block(NULL);
This change confuses me. HGraphBuilder::FinishExitCurrentBlock is only
ever called with either HReturn or HAbnormalExit instructions. I agree
that our block building is in need of hardening, but this seems to
introduce asymmetry to HGraphBuilder::FinishCurrentBlock.
https://codereview.chromium.org/66983002/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/66983002/diff/1/src/hydrogen.h#newcode1466
src/hydrogen.h:1466: void ThenDeopt(const char* reason) {
nit: Let's move that down to line 1474 into the block with the other
deopts.
https://codereview.chromium.org/66983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
