LGTM.
For the record: as discussed, we could save some lithium-codegen code by
blacklisting Tagged representation (hence only requiring code for Double);
but
for now we'll keep the current implementation for two reasons:
(1) no expected performance difference for anticipated use cases
(2) behavior difference: on non-number input, requiring Double would deopt,
which might be undesirable, whereas the current implementation would simply
branch to "false".
https://codereview.chromium.org/63423004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
