On 2013/11/12 12:01:28, Jakob wrote:
Thanks, please take another look.
https://codereview.chromium.org/69413002/diff/1/src/checks.h
File src/checks.h (right):
https://codereview.chromium.org/69413002/diff/1/src/checks.h#newcode272
src/checks.h:272: __attribute__((unused)) // Silence GCC-4.8's warnings.
On 2013/11/12 10:31:42, Benedikt Meurer wrote:
> This will fail on Visual Studio. Please add an appropriate define
> V8_HAS_ATTRIBUTE_UNUSED to include/v8config.h (Clang requires an
__has_attribute
> test, whereas for GCC a version test is sufficient), and define a
V8_UNUSED
> macro based on that, similar to what we do with the other compiler
specific
> stuff.
Done.
LGTM
https://codereview.chromium.org/69413002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
