Revision: 17688
Author: [email protected]
Date: Wed Nov 13 12:18:52 2013 UTC
Log: Fix warnings
[email protected]
BUG=
Review URL: https://codereview.chromium.org/71373003
http://code.google.com/p/v8/source/detail?r=17688
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Wed Nov 13 10:34:06 2013 UTC
+++ /branches/bleeding_edge/include/v8.h Wed Nov 13 12:18:52 2013 UTC
@@ -329,6 +329,8 @@
friend Handle<Boolean> False(Isolate* isolate);
friend class Context;
friend class HandleScope;
+ friend class Object;
+ friend class Private;
V8_INLINE static Handle<T> New(Isolate* isolate, T* that);
=======================================
--- /branches/bleeding_edge/src/api.cc Wed Nov 13 10:34:06 2013 UTC
+++ /branches/bleeding_edge/src/api.cc Wed Nov 13 12:18:52 2013 UTC
@@ -3192,8 +3192,8 @@
bool v8::Object::SetPrivate(v8::Handle<Private> key, v8::Handle<Value>
value) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Set(*key_as_value, value, DontEnum);
+ return Set(v8::Handle<Value>(reinterpret_cast<Value*>(*key)),
+ value, DontEnum);
}
@@ -3249,8 +3249,7 @@
Local<Value> v8::Object::GetPrivate(v8::Handle<Private> key) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Get(*key_as_value);
+ return Get(v8::Handle<Value>(reinterpret_cast<Value*>(*key)));
}
@@ -3454,8 +3453,7 @@
bool v8::Object::DeletePrivate(v8::Handle<Private> key) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Delete(*key_as_value);
+ return Delete(v8::Handle<Value>(reinterpret_cast<Value*>(*key)));
}
@@ -3474,8 +3472,7 @@
bool v8::Object::HasPrivate(v8::Handle<Private> key) {
- v8::Handle<Value>* key_as_value =
reinterpret_cast<v8::Handle<Value>*>(&key);
- return Has(*key_as_value);
+ return Has(v8::Handle<Value>(reinterpret_cast<Value*>(*key)));
}
@@ -6197,9 +6194,7 @@
symbol->set_name(*name);
}
Local<Symbol> result = Utils::ToLocal(symbol);
- v8::Handle<Private>* result_as_private =
- reinterpret_cast<v8::Handle<Private>*>(&result);
- return *result_as_private;
+ return v8::Handle<Private>(reinterpret_cast<Private*>(*result));
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
