LGTM, just a couple of minor nits.
https://codereview.chromium.org/66803002/diff/250002/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/66803002/diff/250002/src/objects.cc#newcode11214
src/objects.cc:11214: object->GetIsolate(),
nit: Indentation is off.
https://codereview.chromium.org/66803002/diff/250002/src/objects.cc#newcode12345
src/objects.cc:12345: Handle<SeededNumberDictionary> new_dictionary;
nit: Let's merge the declaration of "new_dictionary" together with the
definition two lines below. Easier to read.
https://codereview.chromium.org/66803002/diff/250002/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2345
src/objects.h:2345: static Handle<Object> SetDictionaryElement(
It looks like this method is only used from within JSObject. If that is
the case, then we should consider making it private (i.e. moving it down
a couple of lines into the private section).
https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2354
src/objects.h:2354: static Handle<Object> SetFastDoubleElement(
Likewise.
https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode2472
src/objects.h:2472: static void UpdateAllocationSite(Handle<JSObject>
object,
Likewise.
https://codereview.chromium.org/66803002/diff/250002/src/objects.h#newcode3979
src/objects.h:3979: PropertyDetails details);
nit: Indentation is off.
https://codereview.chromium.org/66803002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
