LGTM
https://codereview.chromium.org/62953007/diff/240001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/62953007/diff/240001/src/ic.cc#newcode1202
src/ic.cc:1202: InlineCacheHolderFlag cache_holder =
GetCodeCacheForObject(*object);
We already have cache_holder.
https://codereview.chromium.org/62953007/diff/240001/src/stub-cache.cc
File src/stub-cache.cc (right):
https://codereview.chromium.org/62953007/diff/240001/src/stub-cache.cc#newcode122
src/stub-cache.cc:122: Code::ExtraICState extra_ic_state =
Code::kNoExtraICState;
The "object" argument is not used in this function.
You could either remove it or check that:
*stub_holder == IC::GetCodeCacheHolder(isolate(), *object, cache_holder)
https://codereview.chromium.org/62953007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
