LGTM
https://codereview.chromium.org/68523009/diff/1/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/68523009/diff/1/src/ia32/stub-cache-ia32.cc#newcode3167
src/ia32/stub-cache-ia32.cc:3167: Label* smi_target = &miss;
I think it would be more readable if you would define a predicate and
set smi_target = HasHeapNumberMap() ? &number_case : &miss;
https://codereview.chromium.org/68523009/diff/1/src/ia32/stub-cache-ia32.cc#newcode3170
src/ia32/stub-cache-ia32.cc:3170: if
(map.is_identical_to(isolate()->factory()->heap_number_map())) {
Micro-optimization: keep isolate()->factory()->heap_number_map() in
local variable.
https://codereview.chromium.org/68523009/diff/1/src/ic-inl.h
File src/ic-inl.h (right):
https://codereview.chromium.org/68523009/diff/1/src/ic-inl.h#newcode113
src/ic-inl.h:113: HeapObject* IC::GetCodeCacheHolder(Isolate* isolate,
Indentation is off.
https://codereview.chromium.org/68523009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
