Need to fix the b() branches, as they are incorrect in this usage, see
comments.
https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc
File src/mips/stub-cache-mips.cc (right):
https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#newcode1293
src/mips/stub-cache-mips.cc:1293: __ b(&success);
This is a mistake, b() is a raw branch with delay slot exposed, which I
don't think you want here.
Suggest you use Branch(&success);, but jmp(&label would also work.
https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#newcode1304
src/mips/stub-cache-mips.cc:1304: __ b(&success);
Use Branch() (we used b() before here, which was wrong, and we must have
been lucky with the delay slot.)
https://codereview.chromium.org/72983002/diff/1/src/mips/stub-cache-mips.cc#newcode2655
src/mips/stub-cache-mips.cc:2655: __ b(&success);
Use Branch()
https://codereview.chromium.org/72983002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
