LGTM with comments.
https://codereview.chromium.org/73943004/diff/110001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/73943004/diff/110001/src/runtime.cc#newcode944
src/runtime.cc:944: // Returns true if backing stor e was initialized or
false otherwise.
nit: accidental edit
https://codereview.chromium.org/73943004/diff/110001/src/typedarray.js
File src/typedarray.js (right):
https://codereview.chromium.org/73943004/diff/110001/src/typedarray.js#newcode91
src/typedarray.js:91: throw MakeRangeError(length,
"invalid_typed_array_length");
nit: {} please
https://codereview.chromium.org/73943004/diff/110001/test/mjsunit/regress/regress-319722-ArrayBuffer.js
File test/mjsunit/regress/regress-319722-ArrayBuffer.js (right):
https://codereview.chromium.org/73943004/diff/110001/test/mjsunit/regress/regress-319722-ArrayBuffer.js#newcode33
test/mjsunit/regress/regress-319722-ArrayBuffer.js:33: for (k = 8; k >=
1 && ab == null; k = k/2) {
the update step should be "k = k >> 1", otherwise "k >= 1" will never
become false and a low memory condition will lead to an endless loop.
https://codereview.chromium.org/73943004/diff/110001/test/mjsunit/regress/regress-319722-Float32Array.js
File test/mjsunit/regress/regress-319722-Float32Array.js (right):
https://codereview.chromium.org/73943004/diff/110001/test/mjsunit/regress/regress-319722-Float32Array.js#newcode30
test/mjsunit/regress/regress-319722-Float32Array.js:30:
assertThrows(function () { new Float32Array(maxSize); }, RangeError);
We could combine all of these tests into a single file too, right?
https://codereview.chromium.org/73943004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
