As I said before, there's no fundamental difference between Smi and Integer
representation when it comes to -0: Both can't encode it directly, so we
need
(or at least currently have) a flag indicating that the real value could
indeed
have been -0, and in situations where the difference becomes observable
must be
checked accordingly.
Just because Lithium code generation currently happens to make it hard
(impossible? not sure...) to write a test that would fail with this patch
doesn't mean that baking such assumptions into Hydrogen phases is
acceptable.
To put it bluntly: I don't think this patch is a good idea.
https://codereview.chromium.org/61893018/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
