As discussed offline, embedders only require code changes if they store the
result of an AdjustAmountOfExternalAllocatedMemory call in a 32bit integer.
Chromium at least doesn't do that. Otherwise, a simple recompile is
sufficient
(and we don't promise binary compatibility anyways).
Also, the existing API is inherently broken and can easily cause misbehavior
(GCs not happening when they should, and happening when they should not) as
well
as crashes on shutdown. If I change the CL description to the following,
would
that make you happy?
"API: Change AdjustAmountOfExternalAllocatedMemory calls to use int64_t
instead
of intptr_t
This prevents an overflow in FreeArrayBuffer, which in turn caused needless
GCs
as well as crashes on isolate teardown.
LOG=Y"
https://codereview.chromium.org/70233010/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
