LGTM with nits
https://chromiumcodereview.appspot.com/75413002/diff/30001/src/ic-inl.h
File src/ic-inl.h (right):
https://chromiumcodereview.appspot.com/75413002/diff/30001/src/ic-inl.h#newcode124
src/ic-inl.h:124: if (type->Is(Type::Boolean())) return PROTOTYPE_MAP;
Nit: why not use a disjunction?
https://chromiumcodereview.appspot.com/75413002/diff/30001/src/ic.h
File src/ic.h (right):
https://chromiumcodereview.appspot.com/75413002/diff/30001/src/ic.h#newcode166
src/ic.h:166: static Handle<Map> GetMap(Type* type, Isolate* isolate);
Nit: I'd prefer names that make clearer that it's a conversion, e.g.,
TypeToMap/MapToType or EncodeType/DecodeType.
https://chromiumcodereview.appspot.com/75413002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
