https://codereview.chromium.org/75283002/diff/1/build/features.gypi
File build/features.gypi (right):
https://codereview.chromium.org/75283002/diff/1/build/features.gypi#newcode63
build/features.gypi:63: 'v8_use_default_platform%': 1,
On 2013/11/18 16:27:56, jochen wrote:
On 2013/11/18 15:34:44, Benedikt Meurer wrote:
> Do we really need this option here? Couldn't we just always include
our
default
> implementation, and in V8::Initialize just check whether g_platform
is NULL,
and
> if so, automagically use the default implementation?
The default implementation will have to provide e.g. a thread pool, so
it's a
non-trivial amount of code which I'd like to avoid including if
possible.
Also, V8::Initialize just picking a default implementation is too much
magic
IMO. It would lead to unexpected results if we e.g. add a new process
in chrome
and forget to set the platform there.
Hm, so the default implementation is not used by Chrome? What worries me
is that we may then run into trouble with reproducing Chrome behavior in
d8. We'll have to regularily sync the default implementation with
Chrome, which is certainly not what we want. Can we do better here?
https://codereview.chromium.org/75283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
