LGTM with comments.
https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/common_includes.py
File tools/push-to-trunk/common_includes.py (right):
https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/common_includes.py#newcode237
tools/push-to-trunk/common_includes.py:237: def DieInFocedMode(self,
msg=""):
s/Foced/Forced/
https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/push_to_trunk.py
File tools/push-to-trunk/push_to_trunk.py (right):
https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/push_to_trunk.py#newcode386
tools/push-to-trunk/push_to_trunk.py:386: self.DieInFocedMode("Please
specify the path to a Chromium checkout in "
Wouldn't it make more sense to skip the entire Chrome section in forced
mode?
https://codereview.chromium.org/67763005/diff/1/tools/push-to-trunk/push_to_trunk.py#newcode540
tools/push-to-trunk/push_to_trunk.py:540: help="Don't promt to the
user.",
s/promt to/prompt/
https://codereview.chromium.org/67763005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
