Reviewers: danno,
Message:
Hi Danno, for later after the push to trunk, here is a fix for the build
issues
you saw.
Thx,
--Michael
Description:
Re-enable EnsureAllocationSiteDependentCodesProcessed.
The problem was that we don't use crankshaft on non-sse2 builds.
(on ARM non-vfp3).
Please review this at https://codereview.chromium.org/77963002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -3 lines):
M test/cctest/cctest.status
M test/cctest/test-heap.cc
Index: test/cctest/cctest.status
diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status
index
d73399f676d38caf00c894dd35e191f39a02a69d..ad7ee9157bca585702f6fbaba84629b5077b4bcb
100644
--- a/test/cctest/cctest.status
+++ b/test/cctest/cctest.status
@@ -30,9 +30,6 @@
# All tests prefixed with 'Bug' are expected to fail.
'test-api/Bug*': [FAIL],
- # TODO(mvstanton): reenable when I figure out why it fails on no-sse2
builds
- 'test-heap/EnsureAllocationSiteDependentCodesProcessed': [SKIP],
-
##############################################################################
# BUG(382): Weird test. Can't guarantee that it never times out.
'test-api/ApplyInterruption': [PASS, TIMEOUT],
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index
448c58908db8fb80c8cd2d1f93814324fcbab612..29533d4bd4c405fcf3719c842aa4e0290073178b
100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -3570,6 +3570,8 @@ TEST(EnsureAllocationSiteDependentCodesProcessed) {
v8::internal::Heap* heap = CcTest::heap();
GlobalHandles* global_handles = isolate->global_handles();
+ if (!isolate->use_crankshaft()) return;
+
// The allocation site at the head of the list is ours.
Handle<AllocationSite> site;
{
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
