Revision: 17899
Author: [email protected]
Date: Wed Nov 20 09:30:46 2013 UTC
Log: Reset overwrite mode for BinaryOpStub unless we can actually make
use of it.
[email protected]
Review URL: https://codereview.chromium.org/77943002
http://code.google.com/p/v8/source/detail?r=17899
Modified:
/branches/bleeding_edge/src/code-stubs.cc
=======================================
--- /branches/bleeding_edge/src/code-stubs.cc Fri Nov 15 17:53:35 2013 UTC
+++ /branches/bleeding_edge/src/code-stubs.cc Wed Nov 20 09:30:46 2013 UTC
@@ -585,6 +585,14 @@
ASSERT(result_state_ <= (has_int_result() ? INT32 : NUMBER) ||
op_ == Token::ADD);
+
+ // Reset overwrite mode unless we can actually make use of it, or may be
able
+ // to make use of it at some point in the future.
+ if ((mode_ == OVERWRITE_LEFT && left_state_ > NUMBER) ||
+ (mode_ == OVERWRITE_RIGHT && right_state_ > NUMBER) ||
+ result_state_ > NUMBER) {
+ mode_ = NO_OVERWRITE;
+ }
if (old_state == GetExtraICState()) {
// Tagged operations can lead to non-truncating HChanges
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
