https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py
File test/benchmarks/testcfg.py (right):
https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py#newcode68
test/benchmarks/testcfg.py:68: "octane/gbemu-part2",
On 2013/11/20 09:35:15, Jakob wrote:
Nope, this doesn't do what you want. Skip this entry, keep only
gbemu-part1, and
see my comment below at GetFlagsForTestCase.
Done.
https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py#newcode76
test/benchmarks/testcfg.py:76:
On 2013/11/20 09:35:15, Jakob wrote:
please add typescript and zlib too.
Done.
https://codereview.chromium.org/67763007/diff/1/test/benchmarks/testcfg.py#newcode113
test/benchmarks/testcfg.py:113:
result.append(os.path.join(self.testroot, "octane/base.js"))
On 2013/11/20 09:35:15, Jakob wrote:
you'll need more special-casing here to support multi-file tests:
if testcase.path.startswith("octane/gbemu"):
result.append(..., "octane/gbemu-part2.js"))
elif testcase.path.startswith("octane/typescript"):
result.append(..., "octane/typescript-compiler.js"))
result.append(..., "octane/typescript-input.js"))
elif testcase.path.startswith("octane/zlib"):
result.append(..., "octane/zlib-data.js")
Done.
https://codereview.chromium.org/67763007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
