Revision: 17910
Author: [email protected]
Date: Wed Nov 20 11:21:51 2013 UTC
Log: Remove deprecated v8::SetResourceConstraints without Isolate
parameter
LOG=Y
[email protected]
Review URL: https://codereview.chromium.org/62193003
http://code.google.com/p/v8/source/detail?r=17910
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
/branches/bleeding_edge/test/cctest/test-api.cc
/branches/bleeding_edge/test/cctest/test-strings.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Wed Nov 20 10:59:13 2013 UTC
+++ /branches/bleeding_edge/include/v8.h Wed Nov 20 11:21:51 2013 UTC
@@ -3841,11 +3841,6 @@
};
-V8_DEPRECATED(
- "Use SetResourceConstraints(isolate, constraints) instead",
- bool V8_EXPORT SetResourceConstraints(ResourceConstraints*
constraints));
-
-
/**
* Sets the given ResourceConstraints on the given Isolate.
*/
=======================================
--- /branches/bleeding_edge/src/api.cc Tue Nov 19 14:28:07 2013 UTC
+++ /branches/bleeding_edge/src/api.cc Wed Nov 20 11:21:51 2013 UTC
@@ -608,13 +608,6 @@
void ResourceConstraints::ConfigureDefaults(uint64_t physical_memory) {
ConfigureDefaults(physical_memory, i::CPU::NumberOfProcessorsOnline());
}
-
-
-bool SetResourceConstraints(ResourceConstraints* constraints) {
- i::Isolate* isolate = EnterIsolateIfNeeded();
- return SetResourceConstraints(reinterpret_cast<Isolate*>(isolate),
- constraints);
-}
bool SetResourceConstraints(Isolate* v8_isolate,
=======================================
--- /branches/bleeding_edge/test/cctest/test-api.cc Wed Nov 20 10:59:13
2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-api.cc Wed Nov 20 11:21:51
2013 UTC
@@ -4263,7 +4263,7 @@
v8::ResourceConstraints constraints;
constraints.set_max_young_space_size(256 * K);
constraints.set_max_old_space_size(5 * K * K);
- v8::SetResourceConstraints(&constraints);
+ v8::SetResourceConstraints(CcTest::isolate(), &constraints);
// Execute a script that causes out of memory.
LocalContext context;
@@ -4304,7 +4304,7 @@
v8::ResourceConstraints constraints;
constraints.set_max_young_space_size(256 * K);
constraints.set_max_old_space_size(5 * K * K);
- v8::SetResourceConstraints(&constraints);
+ v8::SetResourceConstraints(CcTest::isolate(), &constraints);
v8::HandleScope scope(CcTest::isolate());
Local<ObjectTemplate> templ = ObjectTemplate::New();
@@ -4333,7 +4333,7 @@
v8::ResourceConstraints constraints;
constraints.set_max_young_space_size(256 * K);
constraints.set_max_old_space_size(4 * K * K);
- v8::SetResourceConstraints(&constraints);
+ v8::SetResourceConstraints(CcTest::isolate(), &constraints);
// Execute a script that causes out of memory.
v8::V8::IgnoreOutOfMemoryException();
@@ -17172,7 +17172,7 @@
// Set stack limit.
v8::ResourceConstraints constraints;
constraints.set_stack_limit(set_limit);
- CHECK(v8::SetResourceConstraints(&constraints));
+ CHECK(v8::SetResourceConstraints(CcTest::isolate(), &constraints));
// Execute a script.
LocalContext env;
@@ -17196,7 +17196,7 @@
// Set stack limit.
v8::ResourceConstraints constraints;
constraints.set_stack_limit(set_limit);
- CHECK(v8::SetResourceConstraints(&constraints));
+ CHECK(v8::SetResourceConstraints(CcTest::isolate(), &constraints));
// Execute a script.
v8::HandleScope scope(CcTest::isolate());
@@ -18646,7 +18646,7 @@
v8::ResourceConstraints constraints;
constraints.set_max_young_space_size(256 * K);
constraints.set_max_old_space_size(4 * K * K);
- v8::SetResourceConstraints(&constraints);
+ v8::SetResourceConstraints(CcTest::isolate(), &constraints);
break;
}
=======================================
--- /branches/bleeding_edge/test/cctest/test-strings.cc Thu Sep 19 13:30:47
2013 UTC
+++ /branches/bleeding_edge/test/cctest/test-strings.cc Wed Nov 20 11:21:51
2013 UTC
@@ -1213,7 +1213,7 @@
v8::ResourceConstraints constraints;
constraints.set_max_young_space_size(256 * K);
constraints.set_max_old_space_size(4 * K * K);
- v8::SetResourceConstraints(&constraints);
+ v8::SetResourceConstraints(CcTest::isolate(), &constraints);
// String s is made of 2^17 = 131072 'c' characters and a is an array
// starting with 'bad', followed by 2^14 times the string s. That means
the
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
