LGTM with a nit.
https://codereview.chromium.org/78183002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/78183002/diff/1/src/hydrogen.cc#newcode8585
src/hydrogen.cc:8585: if (result->HasObservableSideEffects() ||
result->IsPhi()) {
Please add a comment about the "IsPhi()" part, it is not really obvious
why it is there.
https://codereview.chromium.org/78183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
