Definitely heading in the right direction, I like this a lot.
https://codereview.chromium.org/78283002/diff/60001/src/arguments.cc
File src/arguments.cc (right):
https://codereview.chromium.org/78283002/diff/60001/src/arguments.cc#newcode120
src/arguments.cc:120: double ClobberDoubleRegisters(double x1, double
x2, double x3, double x4) {
This is pretty fragile. How about making this a platform-specific
function that is written in assembly? It also doesn't need to be #if
DEBUG, either, the linker will strip it if it's not used, and I prefer
to compile all code if possible.
https://codereview.chromium.org/78283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
