Revision: 17930
Author:   [email protected]
Date:     Wed Nov 20 14:20:07 2013 UTC
Log:      Re-enable EnsureAllocationSiteDependentCodesProcessed.

The problem was that we don't use crankshaft on non-sse2 builds.
(on ARM non-vfp3).

[email protected]

Review URL: https://codereview.chromium.org/77963002
http://code.google.com/p/v8/source/detail?r=17930

Modified:
 /branches/bleeding_edge/test/cctest/cctest.status
 /branches/bleeding_edge/test/cctest/test-heap.cc

=======================================
--- /branches/bleeding_edge/test/cctest/cctest.status Wed Nov 20 08:55:20 2013 UTC +++ /branches/bleeding_edge/test/cctest/cctest.status Wed Nov 20 14:20:07 2013 UTC
@@ -30,9 +30,6 @@
   # All tests prefixed with 'Bug' are expected to fail.
   'test-api/Bug*': [FAIL],

- # TODO(mvstanton): reenable when I figure out why it fails on no-sse2 builds
-  'test-heap/EnsureAllocationSiteDependentCodesProcessed': [SKIP],
-
##############################################################################
   # BUG(382): Weird test. Can't guarantee that it never times out.
   'test-api/ApplyInterruption': [PASS, TIMEOUT],
=======================================
--- /branches/bleeding_edge/test/cctest/test-heap.cc Tue Nov 19 17:29:43 2013 UTC +++ /branches/bleeding_edge/test/cctest/test-heap.cc Wed Nov 20 14:20:07 2013 UTC
@@ -3570,6 +3570,8 @@
   v8::internal::Heap* heap = CcTest::heap();
   GlobalHandles* global_handles = isolate->global_handles();

+  if (!isolate->use_crankshaft()) return;
+
   // The allocation site at the head of the list is ours.
   Handle<AllocationSite> site;
   {

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to