LGTM with a nit and a suggestion for a TODO.
https://codereview.chromium.org/78683002/diff/30001/tools/push-to-trunk/push_to_trunk.py
File tools/push-to-trunk/push_to_trunk.py (right):
https://codereview.chromium.org/78683002/diff/30001/tools/push-to-trunk/push_to_trunk.py#newcode155
tools/push-to-trunk/push_to_trunk.py:155: # (1) Strip comments, (2)
eliminate tabs, (3) fix too little and (4) too
This section is a candidate for Pythonification. Instead of the MSub()
call sequence, every line should go through .strip() (if that's even
necessary to do explicitly) and the new Fill80(). Then these comments
will be unnecessary.
(Feel free to do that in a subsequent CL.)
https://codereview.chromium.org/78683002/diff/30001/tools/push-to-trunk/test_scripts.py
File tools/push-to-trunk/test_scripts.py (right):
https://codereview.chromium.org/78683002/diff/30001/tools/push-to-trunk/test_scripts.py#newcode66
tools/push-to-trunk/test_scripts.py:66: StripComments("###\n# \n\n#
Line 1\nLine 2 ### Test\n #"))
nit: 80col
https://codereview.chromium.org/78683002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
