Reviewers: mvstanton,
Message:
Hey Michael,
Here's a nice one for you. Finally found a solution to the string length
overflow problem. PTAL :-)
-- Benedikt
Description:
Fix combined string length computation.
For 31-bit smis, we don't need to explicitly check whether the
combined string length exceeds the max supported string length,
since the value must be converted to a smi at some point (i.e.
when it is stored into the string length field of the resulting
string), which will emit an overflow check.
For 32-bit smis, we insert an explicit check that the combined
string length does not exceed String::kMaxLength.
This also enables to get rid of the JoinContinuation() usage in
BuildUncheckedStringAdd().
BUG=v8:2990
LOG=n
Please review this at https://codereview.chromium.org/82733003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+206, -217 lines):
M src/hydrogen.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
