Reviewers: danno,
Message:
Committed patchset #1 manually as r17984 (presubmit successful).
Description:
Revert "Use %_IsSmi instead of %MaxSmi."
This reverts r17983.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=17984
Please review this at https://codereview.chromium.org/79263005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -3 lines):
M src/typedarray.js
Index: src/typedarray.js
diff --git a/src/typedarray.js b/src/typedarray.js
index
4c43391e63c4a72da8f5020d3be407191653d650..fc3a608f46ff83afd30b4b1108ac1f24e2419602
100644
--- a/src/typedarray.js
+++ b/src/typedarray.js
@@ -86,8 +86,8 @@ macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME,
ELEMENT_SIZE)
function NAMEConstructByLength(obj, length) {
var l = IS_UNDEFINED(length) ?
- 0 : ToPositiveInteger(length, "invalid_typed_array_length");
- if (!%_IsSmi(l)) {
+ 0 : ToPositiveInteger(length, "invalid_typed_array_length");
+ if (l > %MaxSmi()) {
throw MakeRangeError("invalid_typed_array_length");
}
var byteLength = l * ELEMENT_SIZE;
@@ -98,7 +98,7 @@ macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME,
ELEMENT_SIZE)
function NAMEConstructByArrayLike(obj, arrayLike) {
var length = arrayLike.length;
var l = ToPositiveInteger(length, "invalid_typed_array_length");
- if (!%TypedArrayInitializeFromArrayLike(obj, ARRAY_ID, arrayLike, l)) {
+ if(!%TypedArrayInitializeFromArrayLike(obj, ARRAY_ID, arrayLike, l)) {
for (var i = 0; i < l; i++) {
// It is crucial that we let any execptions from arrayLike[i]
// propagate outside the function.
@@ -108,6 +108,7 @@ macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME,
ELEMENT_SIZE)
}
function NAMEConstructor(arg1, arg2, arg3) {
+
if (%_IsConstructCall()) {
if (IS_ARRAYBUFFER(arg1)) {
NAMEConstructByArrayBuffer(this, arg1, arg2, arg3);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
