On 2013/11/21 17:22:00, Yang wrote:
On 2013/11/21 17:21:22, danno wrote:
> Committed patchset #2 manually as r17981 (presubmit successful).

lgtm.

I confirmed that r17963 exhibits leaks. To reproduce:

export GCC="g++"
export GYP_GENERATORS='ninja'
export BUILDTYPE=Debug
export GYP_DEFINES="linux_use_tcmalloc=1 linux_use_heapchecker=1
linux_keep_shadow_stacks=1 werror= component=shared_library target_arch=x64"
./build/gyp_chromium
ninja -C out/Debug chrome content_shell dump_syms minidump_stackwalk unit_tests
-j2000
tools/heapcheck/chrome_tests.sh -t unit --gtest_filter=EventUnittest.*

https://codereview.chromium.org/80513004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to