Revision: 18002
Author: [email protected]
Date: Fri Nov 22 10:57:55 2013 UTC
Log: Clean up incorrect V8_DEPRECATION macro usage and enable
deprecatitions
We turn the default for standalone builds on, however, I added overrides
to all targets to turn it locally off again. In follow up CLs, I'll
clean up one target at a time.
BUG=v8:3023
[email protected], [email protected]
LOG=n
Review URL: https://codereview.chromium.org/82763004
http://code.google.com/p/v8/source/detail?r=18002
Modified:
/branches/bleeding_edge/build/standalone.gypi
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/samples/samples.gyp
/branches/bleeding_edge/src/d8.gyp
/branches/bleeding_edge/test/cctest/cctest.gyp
/branches/bleeding_edge/tools/gyp/v8.gyp
=======================================
--- /branches/bleeding_edge/build/standalone.gypi Mon Oct 14 13:07:41 2013
UTC
+++ /branches/bleeding_edge/build/standalone.gypi Fri Nov 22 10:57:55 2013
UTC
@@ -37,6 +37,7 @@
'visibility%': 'hidden',
'v8_enable_backtrace%': 0,
'v8_enable_i18n_support%': 1,
+ 'v8_deprecation_warnings': 1,
'msvs_multi_core_compile%': '1',
'mac_deployment_target%': '10.5',
'variables': {
=======================================
--- /branches/bleeding_edge/include/v8.h Thu Nov 21 14:07:06 2013 UTC
+++ /branches/bleeding_edge/include/v8.h Fri Nov 22 10:57:55 2013 UTC
@@ -1736,7 +1736,7 @@
* the function calls 'strlen' to determine the buffer length.
*/
V8_DEPRECATED(
- "Use NewFromOneByte instead",
+ "Use NewFromUtf8 instead",
V8_INLINE static Local<String> New(const char* data, int length =
-1));
/** Allocates a new string from 16-bit character codes.*/
@@ -2535,7 +2535,7 @@
/**
* Returns scriptId object.
*/
- V8_DEPRECATED("Use ScriptId instead", Handle<Value> GetScriptId()) const;
+ V8_DEPRECATED("Use ScriptId instead", Handle<Value> GetScriptId() const);
/**
* Returns scriptId.
@@ -2899,7 +2899,7 @@
V8_DEPRECATED(
"Use ValueOf instead",
- double NumberValue()) const { return ValueOf(); }
+ double NumberValue() const) { return ValueOf(); }
/**
* A specialization of Value::NumberValue that is more efficient
@@ -2937,7 +2937,7 @@
V8_DEPRECATED(
"Use ValueOf instead",
- double NumberValue()) const { return ValueOf(); }
+ double NumberValue() const) { return ValueOf(); }
/**
* Returns the Number held by the object.
@@ -2960,7 +2960,7 @@
V8_DEPRECATED(
"Use ValueOf instead",
- bool BooleanValue()) const { return ValueOf(); }
+ bool BooleanValue() const) { return ValueOf(); }
/**
* Returns the Boolean held by the object.
@@ -2983,7 +2983,7 @@
V8_DEPRECATED(
"Use ValueOf instead",
- Local<String> StringValue()) const { return ValueOf(); }
+ Local<String> StringValue() const) { return ValueOf(); }
/**
* Returns the String held by the object.
@@ -3008,7 +3008,7 @@
V8_DEPRECATED(
"Use ValueOf instead",
- Local<Symbol> SymbolValue()) const { return ValueOf(); }
+ Local<Symbol> SymbolValue() const) { return ValueOf(); }
/**
* Returns the Symbol held by the object.
@@ -6047,7 +6047,7 @@
void Template::Set(const char* name, v8::Handle<Data> value) {
- Set(v8::String::New(name), value);
+ Set(v8::String::NewFromUtf8(Isolate::GetCurrent(), name), value);
}
=======================================
--- /branches/bleeding_edge/samples/samples.gyp Thu Sep 19 12:07:03 2013 UTC
+++ /branches/bleeding_edge/samples/samples.gyp Fri Nov 22 10:57:55 2013 UTC
@@ -39,6 +39,10 @@
'include_dirs': [
'../include',
],
+ 'variables': {
+ # TODO(jochen): enable warnings.
+ 'v8_deprecation_warnings': 0,
+ },
'conditions': [
['v8_enable_i18n_support==1', {
'dependencies': [
=======================================
--- /branches/bleeding_edge/src/d8.gyp Thu Sep 19 12:07:03 2013 UTC
+++ /branches/bleeding_edge/src/d8.gyp Fri Nov 22 10:57:55 2013 UTC
@@ -33,6 +33,12 @@
'v8_enable_vtunejit%': 0,
'v8_enable_i18n_support%': 1,
},
+ 'target_defaults': {
+ 'variables': {
+ # TODO(jochen): enable warnings.
+ 'v8_deprecation_warnings': 0,
+ },
+ },
'includes': ['../build/toolchain.gypi', '../build/features.gypi'],
'targets': [
{
=======================================
--- /branches/bleeding_edge/test/cctest/cctest.gyp Fri Nov 8 17:35:58 2013
UTC
+++ /branches/bleeding_edge/test/cctest/cctest.gyp Fri Nov 22 10:57:55 2013
UTC
@@ -30,6 +30,12 @@
'v8_code': 1,
'generated_file': '<(SHARED_INTERMEDIATE_DIR)/resources.cc',
},
+ 'target_defaults': {
+ 'variables': {
+ # TODO(jochen): enable warnings.
+ 'v8_deprecation_warnings': 0,
+ },
+ },
'includes': ['../../build/toolchain.gypi', '../../build/features.gypi'],
'targets': [
{
=======================================
--- /branches/bleeding_edge/tools/gyp/v8.gyp Fri Nov 22 08:25:50 2013 UTC
+++ /branches/bleeding_edge/tools/gyp/v8.gyp Fri Nov 22 10:57:55 2013 UTC
@@ -30,6 +30,12 @@
'v8_code': 1,
'v8_random_seed%': 314159265,
},
+ 'target_defaults': {
+ 'variables': {
+ # TODO(jochen): enable warnings.
+ 'v8_deprecation_warnings': 0,
+ },
+ },
'includes': ['../../build/toolchain.gypi', '../../build/features.gypi'],
'targets': [
{
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
