On 2013/11/22 11:34:43, Yang wrote:
LGTM with comment (basically what we discussed offline).
https://codereview.chromium.org/82763005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/82763005/diff/1/src/runtime.cc#newcode698
src/runtime.cc:698: free(phantom_array_buffer->backing_store());
Please make sure that this returns afterwards, either by asserting that
should_be_freed() also implies is_external(), or just adding a return
right
after. This would prevent freeing again using the allocator later.
LGTM.
https://codereview.chromium.org/82763005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
