Reviewers: Sven Panne,

Description:
Deprecate old versions of Isolate::SetData and GetData

BUG=none
[email protected]
LOG=y

Please review this at https://codereview.chromium.org/83363003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+3, -12 lines):
  M include/v8.h


Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 51b226236e7c6f167c92bc3f61d313c869c5973e..6e1ac3f5d1e828b0104cafff000e035964887e89 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -4054,11 +4054,9 @@ class V8_EXPORT Isolate {
    */
   void Dispose();

-  /**
-   * Associate embedder-specific data with the isolate. This legacy method
-   * puts the data in the 0th slot. It will be deprecated soon.
-   */
-  V8_INLINE void SetData(void* data);
+  V8_DEPRECATED("Use SetData(0, data) instead.",
+                V8_INLINE void SetData(void* data));
+  V8_DEPRECATED("Use GetData(0) instead.", V8_INLINE void* GetData());

   /**
    * Associate embedder-specific data with the isolate. |slot| has to be
@@ -4067,13 +4065,6 @@ class V8_EXPORT Isolate {
   V8_INLINE void SetData(uint32_t slot, void* data);

   /**
-   * Retrieve embedder-specific data from the isolate. This legacy method
-   * retrieves the data from slot 0. It will be deprecated soon.
-   * Returns NULL if SetData has never been called.
-   */
-  V8_INLINE void* GetData();
-
-  /**
    * Retrieve embedder-specific data from the isolate.
    * Returns NULL if SetData has never been called for the given |slot|.
    */


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to