Reviewers: Jakob,

Message:
Committed patchset #2 manually as r18017 (presubmit successful).

Description:
Make sure files end with exactly one new line and police this in presubmit.

The changes are (excluding presubmit.py) mechanical. I added the following
lines after the check and iterated the presubmit script until all errors
went away:

f = open(name, "w");
if contents.endswith('\n\n'):
  f.write(contents[0:-1])
else:
  f.write(contents + '\n')

[email protected]

Committed: https://code.google.com/p/v8/source/detail?r=18017

Please review this at https://codereview.chromium.org/82803005/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+111, -459 lines):
  M build/all.gyp
  M src/allocation-tracker.h
  M src/arraybuffer.js
  M src/checks.cc
  M src/harmony-array.js
  M src/harmony-string.js
  M src/heap-snapshot-generator-inl.h
  M src/heap-snapshot-generator.h
  M src/ia32/simulator-ia32.cc
  M src/x64/simulator-x64.cc
  M test/cctest/test-unbound-queue.cc
  M test/cctest/test-unique.cc
  M test/intl/collator/sr-sort.js
  M test/intl/overrides/caching.js
  M test/message/isvar.js
  M test/message/paren_in_arg_string.js
  M test/message/replacement-marker-as-argument.js
  M test/message/single-function-literal.js
  M test/mjsunit/arguments-load-across-eval.js
  M test/mjsunit/arguments-read-and-assignment.js
  M test/mjsunit/arguments.js
  M test/mjsunit/array-iteration.js
  M test/mjsunit/array-non-smi-length.js
  M test/mjsunit/array-tostring.js
  M test/mjsunit/bugs/bug-1344252.js
  M test/mjsunit/bugs/bug-proto.js
  M test/mjsunit/closures.js
  M test/mjsunit/compare-character.js
  M test/mjsunit/compare-nan.js
  M test/mjsunit/compiler/control-flow-1.js
  M test/mjsunit/compiler/inline-throw.js
  M test/mjsunit/compiler/lazy-const-lookup.js
  M test/mjsunit/compiler/optimized-closures.js
  M test/mjsunit/compiler/regress-1394.js
  M test/mjsunit/compiler/regress-3260426.js
  M test/mjsunit/compiler/regress-closures-with-eval.js
  M test/mjsunit/compiler/regress-inline-callfunctionstub.js
  M test/mjsunit/compiler/regress-toint32.js
  M test/mjsunit/compiler/rotate.js
  M test/mjsunit/const-declaration.js
  M test/mjsunit/cyclic-array-to-string.js
  M test/mjsunit/debug-breakpoints.js
  M test/mjsunit/debug-constructor.js
  M test/mjsunit/debug-evaluate-const.js
  test/mjsunit/debug-function-scopes.js
  M test/mjsunit/debug-ignore-breakpoints.js
  test/mjsunit/debug-liveedit-3.js
  M test/mjsunit/debug-liveedit-check-stack.js
  M test/mjsunit/debug-liveedit-compile-error.js
  test/mjsunit/debug-liveedit-diff.js
  M test/mjsunit/debug-liveedit-utils.js
  M test/mjsunit/debug-mirror-cache.js
  test/mjsunit/debug-setbreakpoint.js
  M test/mjsunit/debug-stepin-positions.js
  M test/mjsunit/debug-stepout-scope-part1.js
  M test/mjsunit/elide-double-hole-check-9.js
  M test/mjsunit/enumeration-order.js
  M test/mjsunit/error-accessors.js
  M test/mjsunit/eval-stack-trace.js
  M test/mjsunit/extra-arguments.js
  M test/mjsunit/fast-array-length.js
  M test/mjsunit/fast-literal.js
  M test/mjsunit/fun-name.js
  M test/mjsunit/function.js
  M test/mjsunit/get-prototype-of.js
  test/mjsunit/getter-in-value-prototype.js
  M test/mjsunit/global-load-from-eval-in-with.js
  M test/mjsunit/global-load-from-nested-eval.js
  M test/mjsunit/harmony/array-find.js
  M test/mjsunit/harmony/array-findindex.js
  test/mjsunit/harmony/collections.js
  M test/mjsunit/harmony/string-repeat.js
  test/mjsunit/large-object-literal.js
  M test/mjsunit/local-load-from-eval.js
  M test/mjsunit/math-pow.js
  M test/mjsunit/math-round.js
  M test/mjsunit/math-sqrt.js
  M test/mjsunit/mirror-boolean.js
  M test/mjsunit/mirror-undefined.js
  test/mjsunit/mjsunit.js
  M test/mjsunit/mul-exhaustive-part6.js
  test/mjsunit/nans.js
  M test/mjsunit/never-optimize.js
  M test/mjsunit/new.js
  test/mjsunit/newline-in-string.js
  M test/mjsunit/number-tostring-func.js
  M test/mjsunit/number-tostring-small.js
  M test/mjsunit/number-tostring.js
  test/mjsunit/object-literal-conversions.js
  test/mjsunit/object-literal-gc.js
  test/mjsunit/packed-elements.js
  test/mjsunit/property-object-key.js
  test/mjsunit/prototype.js
  M test/mjsunit/regexp-indexof.js
  test/mjsunit/regexp-results-cache.js
  M test/mjsunit/regress/regress-1017.js
  test/mjsunit/regress/regress-1039610.js
  test/mjsunit/regress/regress-105.js
  M test/mjsunit/regress/regress-1066899.js
  M test/mjsunit/regress/regress-1092.js
  test/mjsunit/regress/regress-1099.js
  test/mjsunit/regress/regress-1112.js
  test/mjsunit/regress/regress-1114040.js
  M test/mjsunit/regress/regress-1117.js
  M test/mjsunit/regress/regress-1178598.js
  test/mjsunit/regress/regress-1181.js
  M test/mjsunit/regress/regress-1246.js
  test/mjsunit/regress/regress-1254366.js
  M test/mjsunit/regress/regress-131994.js
  test/mjsunit/regress/regress-137.js
  M test/mjsunit/regress/regress-1546.js
  test/mjsunit/regress/regress-1591.js
  M test/mjsunit/regress/regress-1647.js
  test/mjsunit/regress/regress-166379.js
  M test/mjsunit/regress/regress-1748.js
  M test/mjsunit/regress/regress-1757.js
  test/mjsunit/regress/regress-1853.js
  test/mjsunit/regress/regress-186.js
  test/mjsunit/regress/regress-1919169.js
  M test/mjsunit/regress/regress-193.js
  M test/mjsunit/regress/regress-20070207.js
  test/mjsunit/regress/regress-2027.js
  test/mjsunit/regress/regress-2119.js
  M test/mjsunit/regress/regress-2170.js
  M test/mjsunit/regress/regress-2172.js
  test/mjsunit/regress/regress-2250.js
  M test/mjsunit/regress/regress-2285.js
  test/mjsunit/regress/regress-2289.js
  test/mjsunit/regress/regress-231.js
  test/mjsunit/regress/regress-2374.js
  M test/mjsunit/regress/regress-237617.js
  test/mjsunit/regress/regress-2419.js
  test/mjsunit/regress/regress-2438.js
  M test/mjsunit/regress/regress-2444.js
  M test/mjsunit/regress/regress-246.js
  M test/mjsunit/regress/regress-2570.js
  M test/mjsunit/regress/regress-2596.js
  test/mjsunit/regress/regress-2624.js
  M test/mjsunit/regress/regress-2671-1.js
  test/mjsunit/regress/regress-2671.js
  test/mjsunit/regress/regress-2690.js
  test/mjsunit/regress/regress-298269.js
  test/mjsunit/regress/regress-2984.js
  M test/mjsunit/regress/regress-317.js
  test/mjsunit/regress/regress-319722-ArrayBuffer.js
  M test/mjsunit/regress/regress-45469.js
  test/mjsunit/regress/regress-483.js
  test/mjsunit/regress/regress-588599.js
  M test/mjsunit/regress/regress-619.js
  test/mjsunit/regress/regress-670147.js
  test/mjsunit/regress/regress-674753.js
  M test/mjsunit/regress/regress-675.js
  M test/mjsunit/regress/regress-678525.js
  test/mjsunit/regress/regress-734862.js
  test/mjsunit/regress/regress-74.js
  M test/mjsunit/regress/regress-753.js
  M test/mjsunit/regress/regress-806473.js
  M test/mjsunit/regress/regress-85177.js
  M test/mjsunit/regress/regress-892742.js
  M test/mjsunit/regress/regress-925537.js
  M test/mjsunit/regress/regress-94873.js
  M test/mjsunit/regress/regress-990205.js
  M test/mjsunit/regress/regress-995.js
  M test/mjsunit/regress/regress-998565.js
  M test/mjsunit/regress/regress-add-minus-zero.js
  M test/mjsunit/regress/regress-array-pop-nonconfigurable.js
  M test/mjsunit/regress/regress-binop-nosse2.js
  M test/mjsunit/regress/regress-builtin-array-op.js
  test/mjsunit/regress/regress-crbug-158185.js
  M test/mjsunit/regress/regress-crbug-178790.js
  test/mjsunit/regress/regress-crbug-18639.js
  M test/mjsunit/regress/regress-crbug-222893.js
  M test/mjsunit/regress/regress-crbug-233737.js
  M test/mjsunit/regress/regress-crbug-245480.js
  M test/mjsunit/regress/regress-crbug-259300.js
  test/mjsunit/regress/regress-crbug-3184.js
  M test/mjsunit/regress/regress-frame-details-null-receiver.js
  test/mjsunit/regress/regress-map-invalidation-1.js
  M test/mjsunit/regress/regress-seqstrsetchar-ex1.js
  test/mjsunit/regress/regress-seqstrsetchar-ex2.js
  M test/mjsunit/regress/regress-seqstrsetchar-ex3.js
  M test/mjsunit/regress/regress-transcendental.js
  M test/mjsunit/simple-constructor.js
  M test/mjsunit/sparse-array.js
  test/mjsunit/stack-traces-2.js
  M test/mjsunit/stack-traces-custom-lazy.js
  test/mjsunit/store-dictionary.js
  M test/mjsunit/str-to-num.js
  M test/mjsunit/strict-equals.js
  test/mjsunit/string-natives.js
  M test/mjsunit/string-replace-gc.js
  M test/mjsunit/string-search.js
  M test/mjsunit/string-slices.js
  M test/mjsunit/to-precision.js
  M test/mjsunit/tobool.js
  M test/mjsunit/tools/profile.js
  M test/mjsunit/touint32.js
  test/mjsunit/transcendentals.js
  M test/mjsunit/try-finally-continue.js
  M test/mjsunit/unicode-string-to-number.js
  [[ 190 additional files ]]


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to