Reviewers: ,

Message:
PTAL. Making Add<> and New<> safe as discussed.


https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h
File src/hydrogen.h (right):

https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h#newcode1754
src/hydrogen.h:1754: return I::cast(AddInstruction(instr));
I could probably just make AddInstruction generic instead of adding a
typed variant, but that requires pulling its implementation into header
file. wdyt?

Description:
Safe HGraphBuilder::Add<> and New<>

BUG=

Please review this at https://codereview.chromium.org/82943005/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+88, -42 lines):
  M src/code-stubs-hydrogen.cc
  M src/hydrogen-instructions.h
  M src/hydrogen.h
  M src/hydrogen.cc


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to