I like this. LGTM.
https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/82943005/diff/60001/src/hydrogen.h#newcode1754
src/hydrogen.h:1754: return I::cast(AddInstruction(instr));
On 2013/11/22 15:05:01, Dmitry Lomov (chromium) wrote:
I could probably just make AddInstruction generic instead of adding a
typed
variant, but that requires pulling its implementation into header
file. wdyt?
I think this is OK. We should keep headers as free of complexity as
possible.
https://codereview.chromium.org/82943005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
